Fix build with Symfony 4.3#2841
Merged
Merged
Conversation
teohhanhui
commented
Jun 4, 2019
teohhanhui
commented
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | N/A |
| License | MIT |
| Doc PR | N/A |
teohhanhui
force-pushed
the
fix/build-symfony-4.3
branch
from
June 4, 2019 17:26
7616890 to
12fb583
Compare
teohhanhui
force-pushed
the
fix/build-symfony-4.3
branch
from
June 4, 2019 20:03
12fb583 to
ff6a27b
Compare
teohhanhui
force-pushed
the
fix/build-symfony-4.3
branch
from
June 4, 2019 20:26
ff6a27b to
061067e
Compare
1 task
Member
|
Shouldn't we merge #2784 in 2.4 instead? |
Contributor
Author
|
@dunglas But without the Symfony Messenger changes? As even for experimental code we should not do BC break in a patch version, only in minor version. |
Contributor
Author
|
Or are we able to keep BC on our end? |
Member
|
The BC introduced by Symfony in Messenger is annoying, I'm not really sure of what to do. |
Contributor
Author
|
Maybe we could merge this first. It's harmless. And important to unblock other builds. If we decide to do more (e.g. deprecation fixes), we can do that later? |
Member
|
I agree |
alanpoulain
approved these changes
Jun 5, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.